From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
---|---|
To: | pgsql-patches(at)postgresql(dot)org |
Cc: | Joachim Wieland <joe(at)mcknight(dot)de> |
Subject: | Re: Allow commenting of variables in postgresql.conf to - |
Date: | 2006-05-31 16:13:04 |
Message-ID: | 447DC090.7050000@sun.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
There is second version of patch. I made following changes:
- fix problem with assertion
- use boot_val instead default_val for all configuration data types
- add GUC_JUST_RELOAD status to track what is in configuration file or not
- revert only commented out variables
- add message what is revert to boot value
Joachim, could you explain me second point? I cannot determine
described problem. By my opinion my patch does not change this behavior.
Zdenek
Joachim Wieland wrote:
> Zdenek,
>
> Three points after a quick test:
>
> - please compile with --enable-cassert, there are wrong assertions in your
> code (you might just have to move some lines, there is an Assert() and an
> assignment thereafter)
>
> - changing a PGC_POSTMASTER should show a message:
> => parameter \"%s\" cannot be changed after server start;
> configuration file change ignored
> This seems to not show up anymore with your patch.
>
> - with the same reasoning, I think it's a good idea to display a message
> about which option falls back to its default value.
>
>
> Joachim
>
>
Attachment | Content-Type | Size |
---|---|---|
pg_conf.patch | text/x-patch | 13.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-05-31 16:26:21 | Re: copy with compression progress n |
Previous Message | Dave Page | 2006-05-31 15:48:12 | Re: Possible TODO item: copy to/from pipe |
From | Date | Subject | |
---|---|---|---|
Next Message | Martijn van Oosterhout | 2006-05-31 17:24:59 | Re: [PATCH] Magic block for modules |
Previous Message | Robert Treat | 2006-05-31 15:14:54 | Update link for GUI Tools in FAQ |