Re: [PATCHES] serverlog function (log_destination file)

From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] serverlog function (log_destination file)
Date: 2004-06-10 20:54:54
Message-ID: 40C8CA9E.3030706@pse-consulting.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Sorry I didn't get back on this earlier, yesterday morning my internet
access was literally struck by lightning, I'm running temporary hardware
now.

Bruce Momjian wrote:

>>>>Looks good to me. The only issue I saw was that the default file name
>>>>mentioned in postgresql.conf doesn't match the actual default.
>>>>
>>>>

I'll fix the default filename difference, postgresql.log seems best.
I'll add doc too.

>One idea would be to send a message to stderr when this option is used
>stating that everything is going to 'filename'.
>
>
I can ereport LogFileOpen and LogFileClose, do we need this? Currently,
only open problems will be reported.

>Also can we close/reopen the file on SIGHUP. My guess is we can't
>because of all the backends accessing the output file.
>
>
I'd also like it flushed in pg_logfile and pg_logfile_length, same
problem; any hints welcome.

Regards,
Andreas

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Glen Parker 2004-06-10 21:05:42 Re: Why frequently updated tables are an issue
Previous Message Bruce Momjian 2004-06-10 20:37:26 Re: [PATCHES] serverlog function (log_destination file)

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-06-10 21:26:29 Re: [PATCHES] serverlog function (log_destination file)
Previous Message Bruce Momjian 2004-06-10 20:37:26 Re: [PATCHES] serverlog function (log_destination file)