Re: ICU integration

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ICU integration
Date: 2016-12-28 02:50:42
Message-ID: 3a88fa29-275b-f547-9957-86d4b2cd68db@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Updated patch attached.

The previous round of reviews showed that there was general agreement on
the approach. So I have focused on filling in the gaps, added ICU
support to all the locale-using places, added documentation, fixed some
minor issues that have been pointed out. Everything appears to work
correctly now, and the user-facing feature set is pretty well-rounded.

I don't have much experience with the abbreviated key stuff. I have
filled in what I think should work, but it needs detailed review.

Similarly, some of the stuff in the regular expression code was hacked
in blindly.

One minor problem is that we now support adding any-encoding collation
entries, which violates some of the comments in CollationCreate(). See
FIXME there. It doesn't seem worth major contortions to fix that; maybe
it just has to be documented better.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
v2-0001-ICU-support.patch text/x-patch 149.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2016-12-28 03:10:31 Re: Faster methods for getting SPI results
Previous Message Thomas Munro 2016-12-28 02:28:28 Re: [sqlsmith] Crash reading pg_stat_activity