Skip site navigation (1) Skip section navigation (2)

Re: Fix spinlock usage in UnpinBuffer()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Fix spinlock usage in UnpinBuffer()
Date: 2005-12-29 03:31:46
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
"Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu> writes:
> I agree on this. But before changing it, we need to inspect those spinlocks 
> one by one to making sure two things (1) if there is out-of-line-call, make 
> sure no CHECK_FOR_INTERRUPTS(); (2) ImmediateInterruptsOK is false (99% sure 
> now).

I'm sure of those things already ... but feel free to look for yourself.

>> I think it would be better to substitute our own qsort only on those
>> platforms where we have specifically proved it's a win.
> Our tests indicates that BSD version is better ... but it is just a 
> home-brew test.

Better than what is the operative question.

			regards, tom lane

In response to


pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-12-29 04:02:36
Subject: Re: Extra space character in PL/pgSQL documentation
Previous:From: Qingqing ZhouDate: 2005-12-29 03:06:20
Subject: Re: Fix spinlock usage in UnpinBuffer()

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group