Skip site navigation (1) Skip section navigation (2)

Re: pg_dump --split patch

From: Joel Jacobson <joel(at)gluefinance(dot)com>
To: Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pg_dump --split patch
Date: 2010-12-28 21:44:13
Message-ID: 3393745585032791441@unknownmsgid (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Sent from my iPhone

On 28 dec 2010, at 21:45, Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com> wrote:

The problem I see with suffixing a sequence id to the objects with name
collision is that one day the dump may name myfunc(int) as myfunc.sql and
after an overloaded version is created, say myfunc(char, int), then the same
myfunc(int) may be dumped in myfunc-2.sql, which again is non-deterministic.

I agree, good point!
Perhaps abbreviations are to prefer, e.g., myfunc_i, myfunc_i_c, etc to
reduce the need of truncating filenames.

Also, it is a project policy that we do not introduce new features in back
branches, so spending time on an 8.4.6 patch may not be the best use of your

My company is using 8.4 and needs this feature, so I'll have to patch it
anyway :)

@ EnterpriseDB - The Enterprise Postgres Company

singh(dot)gurjeet(at){ gmail | yahoo }.com
Twitter/Skype: singh_gurjeet

Mail sent from my BlackLaptop device

In response to


pgsql-hackers by date

Next:From: Karl LehenbauerDate: 2010-12-28 21:52:44
Subject: Re: Patch to add table function support to PL/Tcl (Todo item)
Previous:From: Peter EisentrautDate: 2010-12-28 21:41:20
Subject: 9.1alpha3 bundled -- please verify

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group