Skip site navigation (1) Skip section navigation (2)

Re: filenames in pg_basebackup

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgtranslation-translators <pgtranslation-tanslators(at)pgfoundry(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: filenames in pg_basebackup
Date: 2012-07-25 20:25:36
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> I notice that pg_basebackup has lots of messages where file names are
> not in quotes.  Is this okay?

They should be in double quotes, per our message style guidelines.

> msgid "%s: segment file '%s' is incorrect size %d, skipping\n"
> I also wonder about "is" vs. "has" in the above message.

Yeah, "has" would be more correct.

> Apparently, this needs a thorough revision ...

Evidently.  Peter tends to see to that sort of thing while he works on
translations, but I'm sure he wouldn't mind some help.

			regards, tom lane

In response to


pgsql-hackers by date

Next:From: Tom LaneDate: 2012-07-25 20:30:10
Subject: Re: Re: [BUGS] BUG #6733: All Tables Empty After pg_upgrade (PG 9.2.0 beta 2)
Previous:From: Tom LaneDate: 2012-07-25 20:09:42
Subject: Re: [BUGS] BUG #6733: All Tables Empty After pg_upgrade (PG 9.2.0 beta 2)

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group