Re: pg_upgrade from 8.3.4 issue

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Merlin Moncure <mmoncure(at)gmail(dot)com>
Cc: Justin Arnold <jharnold81(at)gmail(dot)com>, pgsql-general(at)postgresql(dot)org
Subject: Re: pg_upgrade from 8.3.4 issue
Date: 2011-08-30 21:17:16
Message-ID: 27390.1314739036@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

I wrote:
> I think it'd be a lot safer to modify (or just remove) the test in
> pg_upgrade. It looks like a one-liner:

Specifically, the attached patch takes care of the problem. Thanks
for reporting it!

regards, tom lane

diff --git a/contrib/pg_upgrade/check.c b/contrib/pg_upgrade/check.c
index 9690695..93b9e69 100644
*** a/contrib/pg_upgrade/check.c
--- b/contrib/pg_upgrade/check.c
*************** check_for_prepared_transactions(ClusterI
*** 532,538 ****

res = executeQueryOrDie(conn,
"SELECT * "
! "FROM pg_catalog.pg_prepared_xact()");

if (PQntuples(res) != 0)
pg_log(PG_FATAL, "The %s cluster contains prepared transactions\n",
--- 532,538 ----

res = executeQueryOrDie(conn,
"SELECT * "
! "FROM pg_catalog.pg_prepared_xacts");

if (PQntuples(res) != 0)
pg_log(PG_FATAL, "The %s cluster contains prepared transactions\n",

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message John R Pierce 2011-08-30 21:55:20 Re: heavy swapping, not sure why
Previous Message Justin Arnold 2011-08-30 20:58:26 Re: pg_upgrade from 8.3.4 issue