Re: ecpg - GRANT bug

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Lee Kindness <lkindness(at)csl(dot)co(dot)uk>
Cc: pgsql-bugs(at)postgresql(dot)org, maves(at)csl(dot)co(dot)uk, Michael Meskes <meskes(at)postgresql(dot)org>
Subject: Re: ecpg - GRANT bug
Date: 2001-10-12 17:18:49
Message-ID: 27250.1002907129@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Lee Kindness <lkindness(at)csl(dot)co(dot)uk> writes:
> ***************
> *** 1693,1699 ****

> GrantStmt: GRANT privileges ON opt_table relation_name_list TO grantee_list opt_with_grant
> {
> ! $$ = cat_str(8, make_str("grant"), $2, make_str("on"), $4, $5, make_str("to"), $7);
> }
> ;

> --- 1693,1699 ----

> GrantStmt: GRANT privileges ON opt_table relation_name_list TO grantee_list opt_with_grant
> {
> ! $$ = cat_str(7, make_str("grant"), $2, make_str("on"), $4, $5, make_str("to"), $7);
> }
> ;

Uh, isn't the correct fix

! $$ = cat_str(8, make_str("grant"), $2, make_str("on"), $4, $5, make_str("to"), $7, $8);

ISTM your patch loses the opt_with_grant clause. (Of course the backend
doesn't currently accept that clause anyway, but that's no reason for
ecpg to drop it.)

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Bruce Momjian 2001-10-12 17:53:49 Re: Possible bug in ALTER TABLE RENAME COLUMN (PostgreSQL 7.1.3)
Previous Message Lee Kindness 2001-10-12 15:33:00 ecpg - GRANT bug

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2001-10-12 17:22:54 Re: optimizer question
Previous Message Tom Lane 2001-10-12 17:14:38 Re: optimizer question