Re: pg_ugprade test failure on data set with column with default value with type bit/varbit

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Paul Guo <paulguo(at)gmail(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Richard Guo <guofenglinux(at)gmail(dot)com>
Subject: Re: pg_ugprade test failure on data set with column with default value with type bit/varbit
Date: 2018-09-11 20:37:10
Message-ID: 26174.1536698230@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Paul Guo <paulguo(at)gmail(dot)com> writes:
> [ 0001-Fix-pg_upgrade-test-failure-caused-by-the-DDL-below.v2.patch ]

Actually, there's an even easier way to fix this, which is to discard
the special case for BITOID/VARBITOID altogether, and let the "default"
case handle it. Fixing things by removing code is always great when
possible.

Also, it's fairly customary to add a test case that actually exhibits
the behavior you want to fix, so I added a regression test table
that has some bit/varbit columns with defaults. I confirmed that that
makes the pg_upgrade test fail without this ruleutils change.

Pushed with those changes.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-09-11 21:34:41 Re: Collation versioning
Previous Message Konstantin Knizhnik 2018-09-11 20:32:53 Re: [HACKERS] Secondary index access optimizations