Re: statistics process shutting down

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Merlin Moncure" <merlin(dot)moncure(at)rcsonline(dot)com>
Cc: "Win 32 hackers PGSQL" <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: statistics process shutting down
Date: 2004-11-30 21:34:34
Message-ID: 24867.1101850474@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32

"Merlin Moncure" <merlin(dot)moncure(at)rcsonline(dot)com> writes:
> Ah. My bad.
> /backend/port/win32/socket.c

> static void
> TranslateSocketError(void) etc. This puts the value in errno like it is
> suppoed to be.

Hmm. I am strongly tempted to remove src/port/pipe.c and put it into
src/backend/port/win32/socket.c, so it can share this function.

> MS recv() does not (I checked) so this is definately a
> bug in pipe.c, since it is reasonable for the caller to expect errno to
> be set to something.

Can you provide a patch? I'm hesitant to hack code I don't have the
means to test.

regards, tom lane

In response to

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Bruce Momjian 2004-12-01 23:40:18 Re: Beta5 libpq Build broken with MS .NET 2003
Previous Message Merlin Moncure 2004-11-30 21:32:25 Re: statistics process shutting down