Re: pgsql-server: Use canonicalize_path for -D, GUC paths, and paths coming

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server: Use canonicalize_path for -D, GUC paths, and paths coming
Date: 2004-07-12 00:02:47
Message-ID: 2389.1089590567@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> None of these are correct. canonicalize_path is only intended for
>> directory names not file names. (I think the same problem applies
>> to several of your GUC variable changes, too.)

> canonicalize_path changes \ to /, and trims the trailing slash.

... and probably breaks the GUC variables that represent search paths,
rather than single file/directory names. Certainly canonicalizing those
values in toto will not have the desired effects; you'd need to
canonicalize the path elements after they are extracted.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2004-07-12 00:08:44 Re: pgsql-server: Use canonicalize_path for -D, GUC paths,
Previous Message Bruce Momjian 2004-07-11 23:52:06 pgsql-server: Remove: < * Allow moving sequences and toast tables to