From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | jtc331(at)gmail(dot)com |
Cc: | bharath(dot)rupireddyforpostgres(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pg_rewind: warn when checkpoint hasn't happened after promotion |
Date: | 2022-06-08 09:15:09 |
Message-ID: | 20220608.181509.1943479167564278831.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At Tue, 07 Jun 2022 16:05:47 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> At Tue, 07 Jun 2022 12:39:38 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> > One possible way to detect promotion reliably is to look into timeline
> > history files. It is written immediately at promotion even on
> > standbys.
>
> The attached seems to work. It uses timeline history files to identify
> the source timeline. With this change pg_waldump no longer need to
> wait for end-of-recovery to finish.
>
> (It lacks doc part and test.. But I'm not sure how we can test this
> behavior.)
This is a revised version.
Revised getTimelineHistory()'s logic (refactored, and changed so that
it doesn't pick-up the wrong history files).
perform_rewind always identify endtli based on source's timeline
history.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
pg_rewind_fix_2.diff.txt | text/plain | 14.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro Horiguchi | 2022-06-08 09:36:04 | Re: pg_rewind: warn when checkpoint hasn't happened after promotion |
Previous Message | Tomas Vondra | 2022-06-08 08:59:38 | Re: effective_io_concurrency and NVMe devices |