From: | Larry Rosenman <ler(at)lerctr(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: peripatus build failures.... |
Date: | 2018-07-06 23:05:36 |
Message-ID: | 20180706230536.foc3h7xcb3crih57@ler-imac.local |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jul 06, 2018 at 06:40:49PM -0400, Tom Lane wrote:
> Larry Rosenman <ler(at)lerctr(dot)org> writes:
> > anyone want to look at this, or at least give me a clue on how to add
> > this to 10 & below?
>
> I do not like the "-Wl,-z,notext" thing at all. It fails to explain
> why things are working OK in v11/HEAD, which makes me think that it's
> band-aiding something rather than really fixing it.
>
> Perhaps you could spend a bit of time with git bisect and find out
> which commit un-broke things? That should help us narrow down the
> true explanation.
>
> regards, tom lane
Following the advice in the error message, the following ALSO fixes it
(REL_10_STABLE):
borg.lerctr.org /home/ler/Git/postgresql/src/port $ git diff
diff --git a/src/port/Makefile b/src/port/Makefile
index 81f01b25bb..9ef00b3d54 100644
--- a/src/port/Makefile
+++ b/src/port/Makefile
@@ -28,6 +28,7 @@ top_builddir = ../..
include $(top_builddir)/src/Makefile.global
override CPPFLAGS := -I$(top_builddir)/src/port -DFRONTEND $(CPPFLAGS)
+override CFLAGS := -fPIC
LIBS += $(PTHREAD_LIBS)
OBJS = $(LIBOBJS) $(PG_CRC32C_OBJS) chklocale.o erand48.o inet_net_ntop.o \
borg.lerctr.org /home/ler/Git/postgresql/src/port $
Is that more acceptable?
--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 214-642-9640 E-Mail: ler(at)lerctr(dot)org
US Mail: 5708 Sabbia Drive, Round Rock, TX 78665-2106
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2018-07-06 23:12:40 | Re: BUG #14999: pg_rewind corrupts control file global/pg_control |
Previous Message | Tom Lane | 2018-07-06 22:40:49 | Re: peripatus build failures.... |