Re: [PATCH][PROPOSAL] Add enum releation option type

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH][PROPOSAL] Add enum releation option type
Date: 2018-03-07 15:49:32
Message-ID: 20180307154932.bry7bakpr5thsswy@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Nikolay Shaplov wrote:

> Actually that's me who have lost it.

Yeah, I realized today when I saw your reply to Nikita. I didn't
realize it was him submitting a new version of the patch.

> The code with oxford comma would be a
> bit more complicated. We should put such coma when we have 3+ items and do not
> put it when we have 2.
>
> Does it worth it?
>
> As I've read oxford using of comma is not mandatory and used to avoid
> ambiguity.
> "XXX, YYY and ZZZ" can be read as "XXX, YYY, ZZZ" or as "XXX, (YYY and ZZZ)".
> oxford comma is used to make sure that YYY and ZZZ are separate items of the
> list, not an expression inside one item.
>
> But here we hardly have such ambiguity.

Gracious goodness -- the stuff these Brits come up with!

> So I'll ask again, do you really think it worth it?

I'm not qualified to answer this question.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2018-03-07 15:56:32 Re: PATCH: Configurable file mode mask
Previous Message Nikolay Shaplov 2018-03-07 15:40:57 Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead