Re: Proposal: Generic WAL logical messages

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Craig Ringer <craig(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
Subject: Re: Proposal: Generic WAL logical messages
Date: 2016-04-06 14:25:13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2016-04-06 16:20:29 +0200, Andres Freund wrote:
> On 2016-04-06 10:15:59 -0400, Tom Lane wrote:
> > > In some ways it seems like the argument to pg_logical_emit_message(...) should
> > > be 'bytea'. That'd be much more convenient for application use. But then
> > > it's a pain when using it via the text-format SQL interface calls, where
> > > we've got no sensible way to output it.
> There's a bytea version.
> > Well, that's something worth thinking about. I assume that
> > pg_logical_slot_get_changes could be executed in a database different from
> > the one where a change was originated?
> You can execute it, but you'll get an error:
> if (slot->data.database != MyDatabaseId)
> ereport(ERROR,
> (errmsg("replication slot \"%s\" was not created in this database",
> NameStr(slot->;

Or so I thought. A look at the code shows a lack of database filtering
in DecodeLogicalMsgOp(). I think it also misses a FilterByOrigin()


Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-04-06 14:29:12 Re: Proposal: Generic WAL logical messages
Previous Message Tom Lane 2016-04-06 14:24:52 Re: Proposal: Generic WAL logical messages