On Wed, Oct 29, 2008 at 03:48:09PM -0400, Andrew Dunstan wrote:
>>> + /* make sure it's called as a trigger */
>>> + if (!CALLED_AS_TRIGGER(fcinfo))
>>> + elog(ERROR, "suppress_redundant_updates_trigger: must be called as trigger");
>> Shouldn't these all be ereport()?
> Good point.
> I'll fix them.
> Maybe we should fix our C sample trigger, from which this was taken.
Does the attached have the right error code?
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
In response to
pgsql-hackers by date
|Next:||From: Andrew Dunstan||Date: 2008-10-29 20:20:15|
|Subject: Re: minimal update|
|Previous:||From: Gevik Babakhani||Date: 2008-10-29 20:04:27|
|Subject: Re: PostgreSQL network discovery|