Re: [PATCHES] Use non-deprecated APIs for dynloader/darwin.c

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Chris Campbell <chris(at)bignerdranch(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] Use non-deprecated APIs for dynloader/darwin.c
Date: 2007-04-02 20:59:08
Message-ID: 200704022059.l32Kx8h13344@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


Ah, I already had this on the TODO list with URLs, so I will not put it
in the hold queue.

---------------------------------------------------------------------------

Chris Campbell wrote:
> On Oct 8, 2006, at 14:29, Tom Lane wrote:
>
> > Looks good, but I don't think we want to abandon OSX 10.2 support
> > just yet. I'll revise this to use a configure probe for dlopen.
>
> Maybe we can abandon Mac OS X 10.2 in 8.3 and later? And not back-
> port these patches to the 7.x, 8.0, and 8.1 branches?
>
> BTW, I think the configure probe (only on Darwin, correct?) should
> test for the existence of <dlfcn.h>.
>
> > My inclination is to apply this one now, since it only affects OSX
> > and should be easily testable, but to hold off on your other patch
> > for portable Bonjour support until 8.3 devel starts. The portability
> > implications of that one are unclear, and I don't know how to test it
> > either, so I think putting it in now is too much risk.
>
> The Bonjour patch wasn't intended to be portable to other platforms
> just yet. As submitted, it has the same risks/advantages as this
> dlopen() patch -- it only works on 10.3 and later, but isn't
> deprecated in 10.4.
>
> If we want to keep 10.2 support for Bonjour, we can test for both
> DNSServiceDiscovery.h and dns_sd.h in ./configure, and prefer
> dns_sd.h if it's found (which will be the case for 10.3 and 10.4) but
> use DNSServiceDiscovery.h if not (which will be the case for 10.2).
>
> Thanks!
>
> - Chris
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-04-02 21:00:50 Re: [PATCHES] Use non-deprecated APIs for dynloader/darwin.c
Previous Message Heikki Linnakangas 2007-04-02 20:50:49 Re: CheckpointStartLock starvation

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-04-02 21:00:50 Re: [PATCHES] Use non-deprecated APIs for dynloader/darwin.c
Previous Message Bruce Momjian 2007-04-02 20:45:07 Re: non-recursive WITH clause support