Re: [pgsql-patches] O_DIRECT support for Windows

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [pgsql-patches] O_DIRECT support for Windows
Date: 2007-03-27 20:08:33
Message-ID: 200703272008.l2RK8XJ20298@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


Magnus, where are on this?

---------------------------------------------------------------------------

Magnus Hagander wrote:
> We're ok with the alignment issues provided the is code added to reject
> O_DIRECT if the sector size is too large.
>
> We also said we need to see some performance numbers on the effect of
> the patch before it goes in.
>
> //Magnus
>
>
> Bruce Momjian wrote:
> > So, do we want this patch? Are we OK on WIN32 alignment issues?
> >
> > ---------------------------------------------------------------------------
> >
> > ITAGAKI Takahiro wrote:
> >> The attached is a patch to define O_DIRECT by ourselves on Windows,
> >> and to map O_DIRECT to FILE_FLAG_NO_BUFFERING.
> >>
> >> There will be a consistency in our support between Windows and other OSes
> >> that have O_DIRECT. Also, there is the following comment that says, I read,
> >> we should do so.
> >> | handle other flags? (eg FILE_FLAG_NO_BUFFERING/FILE_FLAG_WRITE_THROUGH)
> >>
> >> Is this worth doing? Do we need more performance reports for the change?
> >>
> >> Regards,
> >> ---
> >> ITAGAKI Takahiro
> >> NTT Open Source Software Center
> >
> > [ Attachment, skipping... ]
> >
> >> ---------------------------(end of broadcast)---------------------------
> >> TIP 2: Don't 'kill -9' the postmaster
> >
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: You can help support the PostgreSQL project by donating at
>
> http://www.postgresql.org/about/donate

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2007-03-27 20:24:10 Re: Priorities for users or queries?
Previous Message Simon Riggs 2007-03-27 19:56:37 Re: Concurrent connections in psql

Browse pgsql-patches by date

  From Date Subject
Next Message Marko Kreen 2007-03-27 20:33:22 Re: DEALLOCATE ALL
Previous Message David Fetter 2007-03-27 19:39:04 Re: Arrays of Complex Types