Re: O_DIRECT support for Windows

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: O_DIRECT support for Windows
Date: 2007-01-20 01:41:46
Message-ID: 200701200141.l0K1fk819475@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


So, do we want this patch? Are we OK on WIN32 alignment issues?

---------------------------------------------------------------------------

ITAGAKI Takahiro wrote:
> The attached is a patch to define O_DIRECT by ourselves on Windows,
> and to map O_DIRECT to FILE_FLAG_NO_BUFFERING.
>
> There will be a consistency in our support between Windows and other OSes
> that have O_DIRECT. Also, there is the following comment that says, I read,
> we should do so.
> | handle other flags? (eg FILE_FLAG_NO_BUFFERING/FILE_FLAG_WRITE_THROUGH)
>
> Is this worth doing? Do we need more performance reports for the change?
>
> Regards,
> ---
> ITAGAKI Takahiro
> NTT Open Source Software Center

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: Don't 'kill -9' the postmaster

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-01-20 04:32:30 Re: [GENERAL] Corrupt database?
Previous Message Bruce Momjian 2007-01-20 01:38:38 Re: BUG #2907: pg_get_serial_sequence quoting

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-01-20 01:47:27 Re: scrollable cursor sup. for SPI
Previous Message Bruce Momjian 2007-01-20 01:38:38 Re: BUG #2907: pg_get_serial_sequence quoting