Re: pg_restore COPY error handling

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: pg_restore COPY error handling
Date: 2006-01-26 22:22:57
Message-ID: 200601262222.k0QMMvx22087@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


This needs a little style cleanup but I can do that.

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------

Stephen Frost wrote:
> * Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> > Needs to be changed to handle whitespace in front of the actual 'COPY',
> > unless someone else has a better idea. This should be reasonably
> > trivial to do though... If you'd like me to make that change and send
> > in a new patch, just let me know.
>
> Fixed, using isspace(). Also added an output message to make it a bit
> clearer when a failed COPY has been detected, etc.
>
> Updated patch attached.
>
> Thanks,
>
> Stephen

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Have you searched our list archives?
>
> http://archives.postgresql.org

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Jim C. Nasby 2006-01-26 23:00:08 Re: Adding a --quiet option to initdb
Previous Message Bruce Momjian 2006-01-26 22:09:34 Re: [HACKERS] [GENERAL] [PATCH] Better way to check for getaddrinfo