Re: Interval->day docs and regression tests

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Glaesemann <grzm(at)myrealbox(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Interval->day docs and regression tests
Date: 2005-07-30 18:21:07
Message-ID: 200507301821.j6UIL8a02113@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Michael Glaesemann <grzm(at)myrealbox(dot)com> writes:
> > Please find attached diffs for documentation and simple regression
> > tests for the new interval->day changes.
>
> The buildfarm results suggest that justify_days is broken in the
> integer-datetimes case, eg from panda:
>
> *** ./expected/interval.out Sat Jul 30 16:20:48 2005
> --- ./results/interval.out Sat Jul 30 16:24:31 2005
> ***************
> *** 238,243 ****
> SELECT justify_days(interval '6 months 36 days 5 hours 4 minutes 3 seconds') as "7 mons 6 days 5 hours 4 mins 3 seconds";
> 7 mons 6 days 5 hours 4 mins 3 seconds
> ----------------------------------------
> ! @ 7 mons 6 days 5 hours 4 mins 3 secs
> (1 row)
>
> --- 238,243 ----
> SELECT justify_days(interval '6 months 36 days 5 hours 4 minutes 3 seconds') as "7 mons 6 days 5 hours 4 mins 3 seconds";
> 7 mons 6 days 5 hours 4 mins 3 seconds
> ----------------------------------------
> ! @ 1 mon 186 days 5 hours 4 mins 3 secs
> (1 row)

Thanks, fixed and code cleaned up.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 1.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2005-07-30 18:29:55 Re: [COMMITTERS] pgsql: Add GUC variables to control keep-alive times
Previous Message Rocco Altier 2005-07-30 18:08:20 Re: [COMMITTERS] pgsql: Add GUC variables to control keep-alive times for idle, interval,

Browse pgsql-patches by date

  From Date Subject
Next Message Petr Jelinek 2005-07-30 18:53:14 Re: per user/database connections limit again
Previous Message Bruce Momjian 2005-07-30 17:15:45 Re: P.tch to mention cost-based delay in vacuum reference