Re: compiling with ssl without thread safety still broken

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kris Jurka <books(at)ejurka(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: compiling with ssl without thread safety still broken
Date: 2004-03-27 19:34:07
Message-ID: 200403271934.i2RJY7327164@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Kris Jurka <books(at)ejurka(dot)com> writes:
> > Compiling with ssl without thread safety still broken.
> > pq_initssllib is being incorrectly guarded by ENABLE_THREAD_SAFETY.
>
> Not to mention that it has NO business being declared at some random
> place in the middle of the file. Fix committed, but some further review
> of this mare's-nest seems warranted.

Yuck, I should have looked over this patch more closely.

> This file is getting to be a poster child for the reasons not to use
> #ifdefs :-(

Agreed.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2004-03-27 20:00:28 Re: Updated logging config (was: Initial eventlog support on win32 )
Previous Message Bruce Momjian 2004-03-27 18:17:11 Re: APC/socket fix (final?)