Re: cube and earthdistance diffs

From: Bruno Wolff III <bruno(at)wolff(dot)to>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: cube and earthdistance diffs
Date: 2002-09-10 13:45:02
Message-ID: 20020910134502.GA23937@wolff.to
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Tue, Sep 10, 2002 at 09:18:17 -0400,
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Actually, I though that to make earthdistance, you were going to specify
> > cube/* as a dependency, and have that compile before earthdistance
> > compiled. Maybe that would work, but earthdistance can't install cube.
>
> Agreed, but I'm missing why you'd even need to build cube first. Surely
> all that's really needed to compile earthdistance is access to cube's .h
> files? Just put -I$(srcdir)/../cube into earthdistance's CPPFLAGS.

To do the installcheck for earth distance cube needs to be installed.

I think part of my problem was being used to checks being done after make all,
but before make install. I think for contrib, you would have to build
a different install script from the .in file that would specify to load
the files from the current directory instead of the installed library location.

It just seems easier in this case to tell people to make and install cube
before trying to install and check earthdistance.

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Barry Lind 2002-09-10 17:45:20 Re: JDBC Driver - Batch Prepared Statements
Previous Message Lee Kindness 2002-09-10 13:35:10 fmgr.h: PG_NARGS() for number of arguments passed