Re: [HACKERS] Fixes gram.y

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: lockhart(at)fourpalms(dot)org
Cc: Rod Taylor <rbt(at)zort(dot)ca>, pgsql-patches(at)postgresql(dot)org, Hackers List <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Fixes gram.y
Date: 2002-03-19 16:12:54
Message-ID: 200203191612.g2JGCs329896@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Thomas Lockhart wrote:
> ...
> > I have applied the following new patch. It moves DROP DATABASE as you
> > suggested, and fixes the CREATE TABLE tag to show just CREATE and not
> > CREATE DOMAIN. Actually, CREATE DOMAIN should output just DOMAIN too,

^^^^^^

Should have been CREATE here. Sorry.

> > unless someone can tell my why that is not consistent.
>
> Consistant or not, I'm not sure how only "DOMAIN" emitted as a result of
> "CREATE DOMAIN" could extend to the other operations such as "DROP
> DOMAIN". What would you return for that one? istm that "CREATE" needs to
> show up as the first word in the response, and that if necessary we
> should extend the other CREATE operations to qualify their return string
> also.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-03-19 16:54:44 Re: [HACKERS] Fixes gram.y
Previous Message Bruce Momjian 2002-03-19 16:11:35 Re: [HACKERS] Fixes gram.y

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-03-19 16:15:22 Re: Adding usernames to pg_hba.conf
Previous Message Bruce Momjian 2002-03-19 16:11:35 Re: [HACKERS] Fixes gram.y