Re: Patch to add Heimdal kerberos support

From: Bruce Momjian <root(at)candle(dot)pha(dot)pa(dot)us>
To: pgman(at)candle(dot)pha(dot)pa(dot)us
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Bill Studenmund <wrstuden(at)netbsd(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org, torbjorn(dot)lindh(at)allgon(dot)se
Subject: Re: Patch to add Heimdal kerberos support
Date: 2002-02-23 04:21:01
Message-ID: 200202230421.g1N4L2j19334@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Peter has added the needed Kerberos fixes to CVS for 7.3.

---------------------------------------------------------------------------

pgman wrote:
>
> Peter, I assume this is to be applied to 7.3, right?
>
> ---------------------------------------------------------------------------
>
> Peter Eisentraut wrote:
> > Bill Studenmund writes:
> >
> > > The problem I had with AC_SEARCH_LIBS was that if I don't add all of the
> > > libraries (-lasn1 -lroken etc.) the test program won't compile, even
> > > though the .o compiles fine. Can we make the test only depend on
> > > generating a .o?
> >
> > That wouldn't tell you a whole lot about the existence of a function. You
> > do need to link to be able to verify that.
> >
> > > I'd like to make it a bug fix for 7.2 if we can, so I'd appreciate the
> > > help. I can test any new versions of the patch. :-)
> >
> > The attached patch should handle the different struct members (at least it
> > doesn't break them for me) and it doesn't gratuitously fail on libraries
> > that are not really needed. I haven't done anything about -lasn1 -lroken
> > -lcrypto because I'd need to know what functions you need from there. You
> > should be able to get it to work when you configure thus:
> >
> > $ LIBS='-lasn1 -lroken -lcrypto' ./configure --with-krb5 ...other options...
> >
> > If you can confirm that this patch works I can check it in so it appears
> > in whatever beta3+1 is going to be. However, be aware that we're
> > approaching the first release candidate, and since this issue doesn't
> > represent a regression from 7.1 it's not going to hold up the release.
> >
> > --
> > Peter Eisentraut peter_e(at)gmx(dot)net
>
> Content-Description: Patch
>
> [ Attachment, skipping... ]
>
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 2: you can get off all lists at once with the unregister command
> > (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> + If your life is a hard drive, | 830 Blythe Avenue
> + Christ can be your backup. | Drexel Hill, Pennsylvania 19026

--
Bruce Momjian | http://candle.pha.pa.us
root(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-02-23 04:24:18 Re: Patch to add Heimdal kerberos support
Previous Message Peter Eisentraut 2002-02-23 04:20:19 Re: Patch to add Heimdal kerberos support