Re: make createlang match docs

From: Marko Kreen <marko(at)l-t(dot)ee>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: make createlang match docs
Date: 2001-12-12 23:37:29
Message-ID: 20011212233729.GA5865@l-t.ee
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Wed, Dec 12, 2001 at 03:40:30PM -0500, Tom Lane wrote:
> Marko Kreen <marko(at)l-t(dot)ee> writes:
> > * make createlang match docs: "createlang dbname" did not work.
>
> Unless you can demonstrate that createlang changed behavior recently,
> this is the wrong fix. Breaking existing scripts that use createlang
> is not the way to go; fixing the documentation to match the code is
> the way to go.

in app-createlang.html:
Synopsis

createlang [connection-options...] [langname] dbname

createlang [connection-options...] --list | -l dbname

---

$ createlang --help
...
Usage:
createlang [options] [langname] dbname
....
$ createlang foo
createlang: missing required argument database name
Try 'createlang -?' for help.
$

With my patch:

$ createlang foo
Language to install in database foo:

I would say 'createlang foo' has been error-message-only command
all the 7.x.x, so it should not break anything.

What way the docs should be changed?

--
marko

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Marko Kreen 2001-12-12 23:49:25 Re: make createlang match docs
Previous Message Peter Eisentraut 2001-12-12 22:27:37 Re: make createlang match docs