Skip site navigation (1) Skip section navigation (2)

Re: patch for spelling mistake

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Neil Conway <nconway(at)klamath(dot)dyndns(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: patch for spelling mistake
Date: 2001-07-11 03:01:39
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
> > 
> > Tom is right, diff -c is best, though in the patch you applied, there is
> > no chance for error so I can accept it.  You have unique previous text
> > for each change.
> Sorry about that -- and thanks for the tip (Tom & Bruce).
> I've remade the patch using the make_diff tools -- that seems to
> produce the preferred the format. The updated patch is below.
> I'm going to add this info to the Developer's FAQ, but it seems like
> there are 2 copies -- one plaintext and one HTML: it seems as though
> they are updated simultaneously (according to the CVS logs anyway).
> Which version should I make changes to? Both? Are they generated from
> a single source document somewhere?

I have updated the developers FAQ to mentiton diff -c when I mention
make_diff.  The proces of updateing this file involves using lyx to
convert the html to text, cvs commiting both, and then logging into he
main server, cvs update, then copy the faq's to the web directory.  I
can be more specific if people are interested.

  Bruce Momjian                        |
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-patches by date

Next:From: markMLl.pgsql-generalDate: 2001-07-11 10:00:10
Subject: Re: 2 gig file size limit
Previous:From: Christopher Kings-LynneDate: 2001-07-11 02:09:18
Subject: RE: patch for spelling mistake

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group