Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[])

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Brendan Jurd <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[])
Date: 2008-04-28 20:57:11
Message-ID: 16856.1209416231@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> I came up with the attached patch.

I wasn't envisioning anything anywhere near this invasive. We only
need locations on constants in a few contexts, I think.

BTW, you broke _equalAConst() ... it was a bad idea anyway to recast
it on the assumption that there would never again be more than one
field.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message PFC 2008-04-28 21:00:18 Re: Protection from SQL injection
Previous Message Alvaro Herrera 2008-04-28 20:55:15 Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[])

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2008-04-28 21:01:25 Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[])
Previous Message Alvaro Herrera 2008-04-28 20:55:15 Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[])