Re: [HACKERS] Patch to log usage of temporary files

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, Bill Moran <wmoran(at)collaborativefusion(dot)com>
Cc: "Andrew Dunstan" <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Patch to log usage of temporary files
Date: 2007-01-04 14:56:18
Message-ID: 16750.1167922578@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bill Moran <wmoran(at)collaborativefusion(dot)com> writes:
> Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>> Might be more robust to say
>>> if (trace_temp_files >= 0)

> I specified in the GUC config that minimum allowable value is -1.

I'd still tend to go with Andrew's suggestion because it makes this
particular bit of code self-defending against bad values. Yes, it's
reasonably safe given that bit of coding way over yonder in guc.c,
but there's no particularly good reason why this code has to depend
on that to avoid doing something stupid. And it's easier to understand
too --- you don't have to go looking in guc.c to convince yourself it's
safe.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-01-04 15:00:56 Re: wal_checksum = on (default) | off
Previous Message Simon Riggs 2007-01-04 14:43:18 Re: 8.3 pending patch queue

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-01-04 15:00:56 Re: wal_checksum = on (default) | off
Previous Message Andrew Dunstan 2007-01-04 14:34:42 Re: [HACKERS] Patch to log usage of temporary files