From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
Cc: | pgsql-committers(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pgsql: Make CheckRequiredParameterValues() depend upon correct |
Date: | 2010-04-23 20:04:15 |
Message-ID: | 15496.1272053055@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
sriggs(at)postgresql(dot)org (Simon Riggs) writes:
> Log Message:
> -----------
> Make CheckRequiredParameterValues() depend upon correct combination
> of parameters. Fix bug report by Robert Haas that error message and
> hint was incorrect if wrong mode parameters specified on master.
> Internal changes only. Proposals for parameter simplification on
> master/primary still under way.
> Modified Files:
> --------------
> pgsql/src/backend/access/transam:
> xlog.c (r1.401 -> r1.402)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/xlog.c?r1=1.401&r2=1.402)
> pgsql/src/include/catalog:
> pg_control.h (r1.51 -> r1.52)
> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_control.h?r1=1.51&r2=1.52)
This is a change in pg_control layout and requires a bump to the
pg_control version number (and hence forced initdb's all round).
I think it was quite premature to commit this when the design is
still under active discussion --- you may be forcing two rounds
of initdb on testers, when maybe only one or none would be enough.
Especially when you appear to be in the minority about what the design
should be.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2010-04-23 20:05:59 | Re: pgsql: Make CheckRequiredParameterValues() depend upon correct |
Previous Message | Simon Riggs | 2010-04-23 19:57:19 | pgsql: Make CheckRequiredParameterValues() depend upon correct |
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2010-04-23 20:05:04 | Re: recovery_connections cannot start (was Re: master in standby mode croaks) |
Previous Message | Robert Haas | 2010-04-23 20:04:04 | Re: recovery_connections cannot start (was Re: master in standby mode croaks) |