Re: [PATCH] PL/Python: Add spidata to all spiexceptions

From: "Karl O(dot) Pinc" <kop(at)meme(dot)com>
To: Jan Urbański <wulczer(at)wulczer(dot)org>, Oskari Saarenmaa <os(at)ohmu(dot)fi>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] PL/Python: Add spidata to all spiexceptions
Date: 2012-12-10 18:20:08
Message-ID: 1355163608.4632.0@mofo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 12/09/2012 10:33:59 PM, Karl O. Pinc wrote:
> Hi,
> I don't feel particularly qualified to comment, but in the
> interest of (hopefully) helping with the patch review process
> I'm going to comment anyway.

I've gone ahead and signed up to review this patch.

I can confirm that it compiles against head and
the tests pass. I started up a server
and tried it and it works for me, trapping
the exception and executing the exception code.

So, looks good, as far as it goes.
I await your response to my previous message
in this thread before sending it on a
a committer. There were 2 outstanding
issue raised:

Is this useful enough/proceeding in the right
direction to commit now?

Should some of the logic be moved out of a
subroutine and into the calling code?


Karl <kop(at)meme(dot)com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2012-12-10 18:29:16 Re: Shuffling xlog header files
Previous Message Fujii Masao 2012-12-10 18:04:51 Re: [BUG?] lag of minRecoveryPont in archive recovery