From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
Cc: | James Bardin <jbardin(at)bu(dot)edu>, pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: BUG #5011: Standby recovery unable to follow timeline change |
Date: | 2009-08-26 13:36:21 |
Message-ID: | 11243.1251293781@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> Our last-minute changes in 8.4 to allow checkpoint record to be created,
> while forbidding other WAL insertions, missed that CreateCheckPoint()
> calls AdvanceXLInsertBuffer() which requires a valid ThisTimeLineID to
> be set. We need to initialize ThisTimeLineID before we call
> AdvanceXLInsertBuffer().
Ah-hah ...
> Attached is a straightforward fix which initializes ThisTimeLineID
> before the AdvanceXLInsertBuffer() call. Barring objections, I'll commit
> that.
... but this solution is astonishingly ugly. I think we should move up
the LocalSetXLogInsertAllowed call, instead.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2009-08-26 13:46:40 | Re: BUG #5008: Server Startup Problem - When server is configured for SSL |
Previous Message | Tom Lane | 2009-08-26 13:30:16 | Re: BUG #5008: Server Startup Problem - When server is configured for SSL |