Skip site navigation (1) Skip section navigation (2)

Re: Updated pg_buildext

From: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: PostgreSQL in Debian <pgsql-pkg-debian(at)postgresql(dot)org>
Subject: Re: Updated pg_buildext
Date: 2011-06-18 15:36:57
Message-ID: m2sjr7m9ra.fsf@2ndQuadrant.fr (view raw or flat)
Thread:
Lists: pgsql-pkg-debian
Hi,

Christoph Berg <myon(at)debian(dot)org> writes:
> here's my updated pg_buildext script. Most notable changes are the
> addtion of the "configure" and "install" actions and that it catches
> more errors (set -e, die() calls).

I like your changes!

I recall that doing the build in the vtarget directory was important in
my usage, but it could be that you new -f $makefile style allows to run
the build from any directory…

> Dimitri, do you think that should go into the next postgresql-common
> version?

Yes.

> (Todo: think about a smart and policy-compliant way to update
> debian/control. Also, try using with 9.1 modules.)

As we rely on the extension's Makefile I think we're as good as can be
for 9.1.  For debian/control, we have the mechanism to automatically
derive it from supported-versions, we need to reach on a conclusion
about its use being safe.

The other TODO would be what to do about VPATH unfriendly extensions.
Some of them are using subdirectories where to stash regression tests,
docs, etc.  Then building from another place is a problem:  maybe that's
why you removed my forcing building in $vtarget?

Regards,
-- 
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support

In response to

Responses

pgsql-pkg-debian by date

Next:From: Christoph BergDate: 2011-06-18 18:12:29
Subject: Re: Updated pg_buildext
Previous:From: Christoph BergDate: 2011-06-17 15:25:00
Subject: Updated pg_buildext

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group