Skip site navigation (1) Skip section navigation (2)

Re: [bugfix] DISCARD ALL does not release advisory locks

From: "Merlin Moncure" <mmoncure(at)gmail(dot)com>
To: "Marko Kreen" <markokr(at)gmail(dot)com>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Postgres Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [bugfix] DISCARD ALL does not release advisory locks
Date: 2008-11-26 18:41:10
Message-ID: b42b73150811261041q5d61471at5d2353c95f760de@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Wed, Nov 26, 2008 at 11:06 AM, Marko Kreen <markokr(at)gmail(dot)com> wrote:
>
> I think this should be back-patched as well:
>
> - The fact that disconnect will clean up used resources has been
>  always true, thus most clients assume at some level.
>
> - DISCARD ALL was new feature in 8.3.  It is highly doubtful some
>  adv-locks using project has managed to hard-code dependency on
>  buggy behaviour of DISCARD.
>
> - The bug was reported by regular user who encountered deadlocks
>  on 8.3 because of it.

I see your point but there's a pretty high standard for changing
existing behavior in bugfix releases. It's just as likely to introduce
an application bug as to fix one...suppose the application is using
both 'discard all' for prepared statements and advisory locks for
other purposes.  You could break that application.

merlin

In response to

Responses

pgsql-hackers by date

Next:From: Steve CrawfordDate: 2008-11-26 18:51:23
Subject: Re: What's going on with pgfoundry?
Previous:From: Tom LaneDate: 2008-11-26 18:37:57
Subject: Re: Windowing Function Patch Review -> Standard Conformance

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group