From ec81809e7b373feacd91418e850c44757fbaa1fe Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Tue, 15 Mar 2016 15:37:13 +0100 Subject: [PATCH 3/3] Avoid potential lost rename() of new parameter file in EXEC_BACKEND builds guc.c is making use of rename(), though there are risks to lose the renaming in case of a crash. Hence make use of durable_rename to make things durable. --- src/backend/utils/misc/guc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index edcafce..79e52d8 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -8656,7 +8656,7 @@ write_nondefault_variables(GucContext context) * Put new file in place. This could delay on Win32, but we don't hold * any exclusive locks. */ - rename(CONFIG_EXEC_PARAMS_NEW, CONFIG_EXEC_PARAMS); + (void) durable_rename(CONFIG_EXEC_PARAMS_NEW, CONFIG_EXEC_PARAMS, DEBUG1); } -- 2.7.3