Re: pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge

From: Jeremy Drake <pgsql(at)jdrake(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge
Date: 2011-09-02 06:48:31
Message-ID: alpine.BSO.2.00.1109012342460.27326@resin.csoft.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, 1 Sep 2011, Bruce Momjian wrote:

> Jeremy Drake wrote:
>
> > I am the owner of both mongoose and okapi. Let me know if there's
> > anything you want me to try.
>
> Thanks. I would either like to email you patches to test or get ssh
> access so I can compile it myself.

You can send me patches if you want, but I spent a little time with it
tonight and it seems to be the change to src/include/access/xlog.h:
http://git.postgresql.org/gitweb/?p=postgresql.git;a=blobdiff;f=src/include/access/xlog.h;h=1fd60fb98d7362b677112517a20a41e32227a34f;hp=cdbf63fa76e0e7b154c084191d0df6138e1cbfcc;hb=4bd7333;hpb=d010391ac8f706e17998671534ca1230f68d2f38

Unfortunately, I also had to revert commit
6416a82a62db4e66b2edb0fa8fc83a580c3f1931 to fix compile errors. I expect
you would be able to do something a little more surgical than that...

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Meskes 2011-09-02 08:43:53 pgsql: Fix brace indentation of commit 63d06ef59156719efd0208c62e764a69
Previous Message Andrew Dunstan 2011-09-01 22:07:49 pgsql: Supply missing brace omitted by commit 12613cb6b83cac1aa1e7882e8

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2011-09-02 07:47:26 Re: PATCH: regular logging of checkpoint progress
Previous Message Fazool 2011-09-02 05:58:23 Re: Getting the OID inside the executor