Re: [HACKERS] Fixes gram.y

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Rod Taylor <rbt(at)zort(dot)ca>, <pgsql-patches(at)postgresql(dot)org>, Hackers List <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Fixes gram.y
Date: 2002-03-20 17:15:19
Message-ID: Pine.LNX.4.30.0203201157210.812-100000@peter.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane writes:

> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> >> What's standard about it?
>
> > ISO/IEC 9075-2:1999 clause 19.1 general rule 1 c) to be exact. ;-)
>
> Hmm. Looks like we need a wholesale revision of command tags, indeed.
> At least if we want to consider command tags to be the data that
> satisfies this spec requirement.

We would need to do:

ALTER -> ALTER <type of object>
DROP -> DROP <type of object>
CREATE -> CREATE <type of object>

Those look reasonable, and we already do that in some cases.

CLOSE -> CLOSE CURSOR
DECLARE -> DECLARE CURSOR

No opinion here.

COMMIT -> COMMIT WORK
ROLLBACK -> ROLLBACK WORK

Doesn't matter to me.

DELETE -> DELETE WHERE
UPDATE -> UPDATE WHERE

I'd prefer not to do those.

SET CONSTRAINTS -> SET CONSTRAINT [sic]
SET VARIABLE -> SET TIME ZONE
SET VARIABLE -> SET TRANSACTION
SET VARIABLE -> SET SESSION AUTHORIZATION

The first one looks like a mistake. The other ones we could work on.

It also seems to me that CREATE TABLE AS should not print "SELECT". I
thought Fernando Nasser had fixed that. Maybe I'm not completely up to
date in my sources.

--
Peter Eisentraut peter_e(at)gmx(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bear Giles 2002-03-20 17:40:49 Re: XML
Previous Message Neil Conway 2002-03-20 17:09:16 Re: Notify argument?

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-03-20 17:45:11 Re: [HACKERS] Fixes gram.y
Previous Message Jan Wieck 2002-03-20 16:20:20 Re: Eurodates by default