Skip site navigation (1) Skip section navigation (2)

Fixes for psql describeOneTableDetails

From: Kris Jurka <books(at)ejurka(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Fixes for psql describeOneTableDetails
Date: 2008-10-08 23:36:54
Message-ID: Pine.BSO.4.64.0810081931240.11647@leary.csoft.net (view raw or flat)
Thread:
Lists: pgsql-hackers
Attached are two and a half fixes for problems in psql's 
describeOneTableDetails function.

1) After PQclear(res) we must null res out, so that later error handling 
cleanup doesn't try to PQclear it again.

2) In error cleanup we cannot call printTableCleanup unless we've called 
printTableInit.

3) When describing a sequence it queries the sequence by name and was not 
schema qualifying it which is necessary when describing objects not in the 
search path.  This is still busted because it does not correctly quote the 
identifiers.

Kris Jurka

Attachment: psql-fixes.patch
Description: text/plain (2.0 KB)

Responses

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2008-10-08 23:53:10
Subject: Re: [WIP] plpgsql is not translate-aware
Previous:From: Tom LaneDate: 2008-10-08 23:21:23
Subject: Re: [WIP] plpgsql is not translate-aware

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group