Skip site navigation (1) Skip section navigation (2)

Re: Query ResultSet parsing speedup patch (resend)

From: Kris Jurka <books(at)ejurka(dot)com>
To: Mikko Tiihonen <mikko(dot)tiihonen(at)iki(dot)fi>
Cc: pgsql-jdbc(at)postgresql(dot)org
Subject: Re: Query ResultSet parsing speedup patch (resend)
Date: 2006-10-06 17:26:58
Message-ID: Pine.BSO.4.63.0610061222140.22367@leary2.csoft.net (view raw or flat)
Thread:
Lists: pgsql-jdbc

On Sat, 30 Sep 2006, Mikko Tiihonen wrote:

> This is a resend since I did not get any feedback to this patch when I
> sent it two months ago. Could someone at least have some recommendations
> what I should do to get this patch evaluated or even applied to the
> official source.
>

I like the change to use VisibleBufferedInputStream.  That's a clean way 
of avoiding copies.  I don't particularly like the number parsing changes 
as they're a pretty ugly hack, but I can't deny the performance 
improvements (I saw 30-35%).  I plan on applying this unless someone 
objects.

One bug I found was that you have the wrong bytes.length check in 
getFastInt.  It can handle one more byte than you specified.

Kris Jurka

In response to

Responses

pgsql-jdbc by date

Next:From: Luis Vilar FloresDate: 2006-10-06 19:21:03
Subject: Re: bytea memory improvement - test results
Previous:From: Michael PaesoldDate: 2006-10-06 07:40:15
Subject: Re: [pgsql-jdbc] dollar-quoted CREATE FUNCTION statement fails

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group