Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Allow psql multi-line column values to align

From: Kris Jurka <books(at)ejurka(dot)com>
To: pgman(at)candle(dot)pha(dot)pa(dot)us
Cc: pgsql-committers(at)postgresql(dot)org, kleptog(at)svana(dot)org
Subject: Re: pgsql: Allow psql multi-line column values to align
Date: 2006-02-10 07:25:08
Message-ID: Pine.BSO.4.61.0602100151570.23655@leary.csoft.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-patches

On Thu, 9 Feb 2006, Bruce Momjian wrote:

> Log Message:
> -----------
> Allow psql multi-line column values to align in the proper columns
>

There is a problem with this on AIX.

http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=asp&dt=2006-02-10%2006:23:00

For tables that have no columns AIX thinks it has an out of memory error. 
src/bin/psql/print.c:pg_local_calloc bails out if calloc returns NULL.  I 
believe AIX is returning NULL for calloc with a count of zero.  Efforts 
are made not to call pg_local_calloc with a count of zero, but one place 
is missed, the attached patch fixes that.

Additionally there are a whole lot of of signedness warnings introduced 
which I've attached.

Kris Jurka

Attachment: signwarnings.txt
Description: text/plain (2.7 KB)
Attachment: calloczero.patch
Description: text/plain (985 bytes)

In response to

Responses

pgsql-committers by date

Next:From: Teodor SigaevDate: 2006-02-10 11:18:40
Subject: pgsql: renew output of regression test accordingly to
Previous:From: Kris JurkaDate: 2006-02-10 05:44:29
Subject: Re: pgsql: Allow psql multi-line column values to align

pgsql-patches by date

Next:From: ITAGAKI TakahiroDate: 2006-02-10 09:50:15
Subject: ignore_killed_tuples is always true
Previous:From: Kris JurkaDate: 2006-02-10 05:44:29
Subject: Re: pgsql: Allow psql multi-line column values to align

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group