Skip site navigation (1) Skip section navigation (2)

Re: Schema bug

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Guillaume LELARGE" <guillaume(dot)lelarge(at)gmail(dot)com>,<pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Schema bug
Date: 2005-12-10 00:22:32
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E4E7E85F@ratbert.vale-housing.co.uk (view raw or flat)
Thread:
Lists: pgadmin-hackers
 

> -----Original Message-----
> From: pgadmin-hackers-owner(at)postgresql(dot)org 
> [mailto:pgadmin-hackers-owner(at)postgresql(dot)org] On Behalf Of 
> Guillaume LELARGE
> Sent: 09 December 2005 22:43
> To: pgadmin-hackers(at)postgresql(dot)org
> Subject: Re: [pgadmin-hackers] Schema bug
> 
> Le Vendredi 09 Décembre 2005 09:21, Dave Page a écrit :
> > > -----Original Message-----
> > > From: Florian G. Pflug [mailto:fgp(at)phlo(dot)org]
> > > Sent: 09 December 2005 01:15
> > > To: Dave Page
> > > Cc: Andreas Pflug; pgadmin-hackers
> > > Subject: Re: [pgadmin-hackers] Schema bug
> > >
> > > Hm.. couldn't it check the system-schemas by name instead 
> - so, saying
> > > "it's a non-system schema if it isn't called information_schema or
> > > pg_catalog", instead of "it's a system-schema if oid <
> > > LAST_SYSTEM_OID
> > > and name is not public"? Or are there other system schemas I
> > > don't know
> > > of (quite possible ;-) )?
> >
> > Probably - but it's more of a future-proofing kinda thing. 
> Pretty weak
> > argument though...
> >
> 
> I had two ways to fix this bug : detect system schemas on 
> their names, or 
> detect public schema by its OID. I think it's better to only 
> keep the public 
> schema with its OID, it's much less risky to have a wrong 
> one. That's what 
> the patch is doing :
>   AND nspname != 'public'
> is replaced by
>   AND nsp.oid != 2200
> 
> I still think this patch should be applied.

Does anyone see a reason /not/ to do this?

Regards, Dave.

Responses

pgadmin-hackers by date

Next:From: svnDate: 2005-12-10 14:16:32
Subject: SVN Commit by dpage: r4827 - branches/REL-1_4_0_PATCHES/pgadmin3/pkg/win32/src
Previous:From: Guillaume LELARGEDate: 2005-12-09 22:43:06
Subject: Re: Schema bug

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group