Re: [PATCH] Bugfix for for pkg/mac/complete-bundle.sh

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>, "pgAdmin Hackers" <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Bugfix for for pkg/mac/complete-bundle.sh
Date: 2005-10-24 07:38:04
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E4CC3679@ratbert.vale-housing.co.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks Florian, patch applied.

Regards, Dave.

> -----Original Message-----
> From: pgadmin-hackers-owner(at)postgresql(dot)org
> [mailto:pgadmin-hackers-owner(at)postgresql(dot)org] On Behalf Of
> Florian G. Pflug
> Sent: 24 October 2005 02:35
> To: pgAdmin Hackers
> Subject: [pgadmin-hackers] [PATCH] Bugfix for for
> pkg/mac/complete-bundle.sh
>
> Hi
>
> The hardcoded "todo=../src/pgadmin3" in complete-bundle.sh is wrong.
> complete-bundle.sh
> adjusts the library path _inside_ the binary besides copying the lib
> into the bundle.
> If ../src/pgadmin3, instead of Contents/MacOS/pgAdmin3 is fixed up by
> complete-bundle.sh,
> the resulting bundle will not start on because it can't find the
> dynamically linked libs.
>
> Please apply the following patch - it's already used for the nighty
> builds, and produces working
> bundles.
>
> Index: pkg/mac/complete-bundle.sh
> ===================================================================
> --- pkg/mac/complete-bundle.sh (revision 4597)
> +++ pkg/mac/complete-bundle.sh (working copy)
> @@ -12,10 +12,10 @@
> cd "$bundle"
> fw_basepath=$(dirname $(pwd))
> todo=$(find ./ | \
> - xargs file | \
> - sed -n 's/^\([^:][^:]*\):[[:space:]]*Mach-O
> executable ppc$/\1/p' \
> + xargs --replace=line file 'line' | \
> + sed -n 's/^\([^:][^:]*\):[[:space:]]*Mach-O executable
> ppc$/\1/p' | \
> + xargs echo -n \
> )
> -todo=../src/pgadmin3
>
> echo "Found executables: $todo"
> while test "$todo" != ""; do
>
>
>
>
>
> ---------------------------(end of
> broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings
>

Browse pgadmin-hackers by date

  From Date Subject
Next Message svn 2005-10-24 09:00:18 SVN Commit by dpage: r4600 - trunk/pgadmin3/i18n
Previous Message svn 2005-10-24 07:37:36 SVN Commit by dpage: r4598 - trunk/pgadmin3/pkg/mac