Skip site navigation (1) Skip section navigation (2)

Re: Compiling pgAdmin on SuSE 10.1

From: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
To: "Miha Radej" <miha(dot)radej(at)siix(dot)com>
Cc: "pgadmin-hackers" <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Compiling pgAdmin on SuSE 10.1
Date: 2006-05-30 08:08:00
Message-ID: E7F85A1B5FF8D44C8A1AF6885BC9A0E401388561@ratbert.vale-housing.co.uk (view raw or flat)
Thread:
Lists: pgadmin-hackers
 

> -----Original Message-----
> From: Miha Radej [mailto:miha(dot)radej(at)siix(dot)com] 
> Sent: 29 May 2006 21:27
> To: Dave Page
> Cc: pgadmin-hackers
> Subject: Re: [pgadmin-hackers] Compiling pgAdmin on SuSE 10.1
> 
> Hi!
> 
> Dave Page pravi:
> >> ./frm/frmReport.cpp: In member function 'virtual void
> >> reportObjectDataDictionaryFactory::GenerateReport(frmReport*, 
> >> pgObject*)':
> >> ./frm/frmReport.cpp:1335: warning: cannot pass objects of 
> non-POD type
> >> 'class wxString' through '...'; call will abort at runtime
> > 
> > Yeah, these ones only fail on GCC - it's complaining about passing a
> > wxString as a parameter to a variadic function. The fix is 
> to use the
> > c_str() member, eg.
> 
> The above warnings are now gone, but I noticed these now:
> 
> ./frm/frmEditGrid.cpp: In member function 'void sqlTable::Paste()':
> ./frm/frmEditGrid.cpp:1840: warning: comparison between signed and
> unsigned integer expressions
> ./frm/frmEditGrid.cpp:1841: warning: comparison between signed and
> unsigned integer expressions
> ./frm/frmEditGrid.cpp:1856: warning: comparison between signed and
> unsigned integer expressions
> ./frm/frmEditGrid.cpp:1857: warning: comparison between signed and
> unsigned integer expressions
> 
> The attached patch is yet another "works for me" kind of 
> patch, I don't
> know what good/standard C++ practice is in such situations, 
> considering
> I don't know C++ at all :)

:-)

Modified patch applied. I blind-fixed that one earlier and put the casts
on the wrong operands :-(

Thanks, Dave.

pgadmin-hackers by date

Next:From: svnDate: 2006-05-30 09:54:58
Subject: SVN Commit by dpage: r5214 - in trunk/pgadmin3: . src/frm src/include
Previous:From: svnDate: 2006-05-30 08:06:12
Subject: SVN Commit by dpage: r5213 - trunk/pgadmin3/src/frm

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group