Skip site navigation (1) Skip section navigation (2)

pgAdmin III commit: Fix freeze of UI when querytool has an error on aq

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin III commit: Fix freeze of UI when querytool has an error on aq
Date: 2012-07-14 12:46:10
Message-ID: E1Sq1je-000898-TJ@gothos.postgresql.org (view raw or flat)
Thread:
Lists: pgadmin-hackers
Fix freeze of UI when querytool has an error on a query

We call too many times the GetCharAt() and the GetText().Length() methods.
This fix calls GetCharAt() once per loop (instead of five times per loop), and
GetText().Length() once only (instead of once per loop). My testing shows no
freeze at all with a 4000 lines of SQL code.

Report per Evan Martin.

Branch
------
REL-1_16_0_PATCHES

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=05803e4b89913c7634ff62ff6b1122fb84102eaf

Modified Files
--------------
pgadmin/frm/frmQuery.cpp |   13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)

pgadmin-hackers by date

Next:From: pgAdmin TracDate: 2012-07-14 12:57:35
Subject: [pgAdmin III] #369: Edit data and tables with a unique key
Previous:From: Vinicius SantosDate: 2012-07-14 00:47:20
Subject: Re: More information about the selected objects

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group