Skip site navigation (1) Skip section navigation (2)

pgsql: Use symbolic names not octal constants for file permissionflags

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Use symbolic names not octal constants for file permissionflags
Date: 2010-12-10 22:35:50
Message-ID: E1PRBZ8-0002Da-K4@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Use symbolic names not octal constants for file permission flags.

Purely cosmetic patch to make our coding standards more consistent ---
we were doing symbolic some places and octal other places.  This patch
fixes all C-coded uses of mkdir, chmod, and umask.  There might be some
other calls I missed.  Inconsistency noted while researching tablespace
directory permissions issue.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=04f4e10cfc158239ca00a6ed6a84428c7acb1e6d

Modified Files
--------------
src/backend/access/transam/xlog.c   |    2 +-
src/backend/commands/copy.c         |    2 +-
src/backend/commands/tablespace.c   |    2 +-
src/backend/libpq/be-fsstubs.c      |    7 ++++---
src/backend/postmaster/postmaster.c |    4 ++--
src/backend/postmaster/syslogger.c  |    6 +++---
src/backend/storage/file/copydir.c  |    2 +-
src/backend/storage/ipc/ipc.c       |    4 ++--
src/bin/initdb/initdb.c             |   16 ++++++++--------
src/bin/pg_ctl/pg_ctl.c             |    2 +-
10 files changed, 24 insertions(+), 23 deletions(-)

Responses

pgsql-hackers by date

Next:From: David E. WheelerDate: 2010-12-10 22:35:59
Subject: Re: ALTER EXTENSION ... UPGRADE;
Previous:From: Dimitri FontaineDate: 2010-12-10 22:32:09
Subject: Re: ALTER EXTENSION ... UPGRADE;

pgsql-committers by date

Next:From: Tom LaneDate: 2010-12-11 00:43:17
Subject: pgsql: Move a couple of initdb's subroutines into src/port/.
Previous:From: Tom LaneDate: 2010-12-10 19:21:04
Subject: Re: pgsql: Reduce spurious Hot Standby conflicts from never-visible records

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group