Fix leakage of cost_limit when multiple autovacuum workers are active.
When using default autovacuum_vac_cost_limit, autovac_balance_cost relied
on VacuumCostLimit to contain the correct global value ... but after the
first time through in a particular worker process, it didn't, because we'd
trashed it in previous iterations. Depending on the state of other autovac
workers, this could result in a steady reduction of the effective
cost_limit setting as a particular worker processed more and more tables,
causing it to go slower and slower. Spotted by Simon Poole (bug #5759).
Fix by saving and restoring the GUC variables in the loop in do_autovacuum.
In passing, improve a few comments.
Back-patch to 8.3 ... the cost rebalancing code has been buggy since it was
src/backend/postmaster/autovacuum.c | 63 +++++++++++++++++++++++++----------
1 files changed, 45 insertions(+), 18 deletions(-)
pgsql-committers by date
|Next:||From: Tom Lane||Date: 2010-11-20 03:48:58|
|Subject: Re: pgsql: Speed up conversion of signed integers to C strings. |
|Previous:||From: Tom Lane||Date: 2010-11-20 03:30:00|
|Subject: pgsql: Fix leakage of cost_limit when multiple autovacuum workers area|