pgsql: Fix aboriginal mistake in plpython's set-returning-function supp

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix aboriginal mistake in plpython's set-returning-function supp
Date: 2010-11-15 19:27:52
Message-ID: E1PI4iW-0007Xm-Le@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix aboriginal mistake in plpython's set-returning-function support.

We must stay in the function's SPI context until done calling the iterator
that returns the set result. Otherwise, any attempt to invoke SPI features
in the python code called by the iterator will malfunction. Diagnosis and
patch by Jan Urbanski, per bug report from Jean-Baptiste Quenot.

Back-patch to 8.2; there was no support for SRFs in previous versions of
plpython.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=add0ea88e7722b48d1f3a7c38e3cfd7f1e854674

Modified Files
--------------
src/pl/plpython/expected/plpython_setof.out | 17 ++++++++++++++++
src/pl/plpython/plpython.c | 28 +++++++++++++++++++-------
src/pl/plpython/sql/plpython_setof.sql | 11 ++++++++++
3 files changed, 48 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2010-11-15 21:10:20 Re: [COMMITTERS] pgsql: Improved parallel make support
Previous Message User Andrewd 2010-11-15 17:51:29 pgbuildfarm - client-code: Call run_build.pl directly.