From: | Peter Geoghegan <pg(at)heroku(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, David Zuelke <dz(at)heroku(dot)com> |
Subject: | Re: Fix for OpenSSL error queue bug |
Date: | 2016-03-15 01:44:47 |
Message-ID: | CAM3SWZS0iV1HQ2fqNxvmTZm4+hPLAfH=7LeC4znmFX8az=ARMg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Mar 14, 2016 at 4:11 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> Yes, with one small difference: I wouldn't be calling ERR_get_error()
> in the common case where SSL_get_error() returns SSL_ERROR_NONE, on
> the theory that skipping that case represents no risk. I'm making a
> concession to Peter E's view that that will calling ERR_get_error()
> more will add useless cycles.
The attached patch is what I have in mind.
I can produce a back-patchable variant of this if you and Peter E.
think this approach is okay.
--
Peter Geoghegan
Attachment | Content-Type | Size |
---|---|---|
0001-Distrust-external-OpenSSL-clients-clear-err-queue.patch | text/x-patch | 21.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2016-03-15 02:04:41 | Re: Re: PATCH: Split stats file per database WAS: autovacuum stress-testing our system |
Previous Message | David Rowley | 2016-03-15 01:25:42 | Choosing parallel_degree |