Skip site navigation (1) Skip section navigation (2)

Re: Weird code in pgDomain.cpp

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Sachin Srivastava <sachin(dot)srivastava(at)enterprisedb(dot)com>
Subject: Re: Weird code in pgDomain.cpp
Date: 2012-04-09 14:28:33
Message-ID: CAG7mmoyNhLhFvE1ME9DgFKnWVHR6hJ5iQ9JqggMGfHmAC0tofQ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Sun, Apr 8, 2012 at 3:24 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> On Sun, Apr 8, 2012 at 4:44 AM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
> > Hi,
> >
> > I was trying to fix a bug on dlgDomain, and I found this code (in
> > pgadmin/schema/pgDomain.cpp):
> >
> > wxString conname = set->GetVal(wxT("conname"));
> > if (!conname.StartsWith(wxT("$")))
> >    check += wxT("CONSTRAINT ") + qtIdent(conname) + wxT(" ");
> >
> > I'm wondering why we look for a dollar sign in the first character of a
> > check constraint in a domain. It means nothing to me. Could it be some
> > GreenPlum or EnterpriseDB specific code? or is it something else?
>
> Not that I recall - Ashesh, Sachin - do you know if it's a PPAS thing?
>
Not that I recall.

It's been there from very long time..
i.e. git log 6003c502d89900b2b2e1538d340db028b1880aa1 -p -n 1
schema/pgDomain.cpp

--
Ashesh Vashi

>
> >
> > I'm also wondering if we could drop this code. Doesn't seem to do much,
> > and doesn't help us with modifying a check constraint in a domain.
>
> Dunno.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

pgadmin-hackers by date

Next:From: Ashesh VashiDate: 2012-04-10 09:43:47
Subject: PATCH: CheckAlive on the maintenance database
Previous:From: Ashesh VashiDate: 2012-04-09 07:15:28
Subject: PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group