Re: Review: check existency of table for -t option (pg_dump) when pattern...

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Review: check existency of table for -t option (pg_dump) when pattern...
Date: 2015-09-14 10:07:05
Message-ID: CAFj8pRA7s9x_Y1eGbkbBUPkNYO2zKY2nB_w_AQjYXgq9cnLncg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2015-09-14 12:05 GMT+02:00 Teodor Sigaev <teodor(at)sigaev(dot)ru>:

> (new version in attach), but patch shows some inconsistent output:
>> % pg_dump -t 'aaa*' postgres
>> pg_dump: No matching tables were found
>> % pg_dump -t 'aaa*' --strict-names postgres
>> pg_dump: Table "aaa*" not found.
>>
>
> There are two different situation - first message says "there are not any
>> table
>> for work", second says "There are not specific table(s) with specific
>> names
>> (mask)". I am thinking so this information is enough interesting for
>> showing.
>>
> Agree, but "aaa*" is not a table
>
>
>> Can be changed to "No matching table(s) were found for filter "aaa*" " ?
>>
>
> "TBL" is not a filter. May be:
>
> No matching table(s) were found for pattern "aaa*" ?
> No matching table(s) were found for pattern "TBL" ?

+1

it is better

Pavel

>
>
> --
> Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
> WWW:
> http://www.sigaev.ru/
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2015-09-14 10:09:01 Re: PATCH: index-only scans with partial indexes
Previous Message Teodor Sigaev 2015-09-14 10:05:56 Re: Review: check existency of table for -t option (pg_dump) when pattern...